feat: Extend vscode 'run' command with optional mode argument for run… #20077
Conversation
…ning test(s) or bin at keyboard cursor
rustbot
added
the
S-waiting-on-review
|
To test executing the 'run' command with 'cursor' as supplied argument one can for example add the following to keybindings.json: |
editors/code/src/ctx.ts
Outdated
| if (name === "run") { | ||
| // Special case: support optional argument for `run` | ||
| callback = (mode?: "cursor") => { | ||
| return commands.run(this, mode)(); | ||
| }; | ||
| } else { | ||
| // we asserted that `client` is defined | ||
| callback = factory.enabled(this); | ||
| } |
There was a problem hiding this comment.
I don't think this is necessary, Cmd (the type of callback) is already correctly typed in allowing more parameters. Instead we need to change the enabled field here
rust-analyzer/editors/code/src/main.ts
Line 170 in ab9e7bd
There was a problem hiding this comment.
Ah In fact that doesn't need changes either. Just having edited the signature of command.run should suffice
There was a problem hiding this comment.
I changed it. I've tried to only revert the special casing in command factory (ctx.ts). However it seems adding the special callback as you suggest in your first comment is necessary to make it work.
There was a problem hiding this comment.
Ah indeed, enabled is not a Cmd but a function that returns a Cmd 👍
…update main.createCommands instead
|
Thanks! |
…ning test(s) or bin at keyboard cursor
Fixes #14805